Skip to content

Versioned Analytics Consent and Immediate Withdrawal - #1106

Merged
Manuelshub merged 1 commit into
Nanle-code:masterfrom
deslawson:master
Sep 28, 2026
Merged

Manuelshub merged 1 commit into
Nanle-code:masterfrom
deslawson:master

Conversation

@deslawson

@deslawson deslawson commented Sep 28, 2026 •

Copy link
Copy Markdown

Summary

Prompts users to review analytics consent when the policy changes, and stops telemetry promptly when consent is withdrawn. Adds storage failure handling, tests, and consent documentation.

How was this tested?

  • corepack pnpm exec vitest run --config vitest.config.js src/utils/__tests__/analyticsConsent.test.ts src/utils/__tests__/analytics.circuitBreaker.test.ts src/utils/__tests__/monitoring.consent.test.ts — 15 tests passed. Covers consent grant and withdrawal, stale policy re-prompting, malformed or unavailable storage, failed saves, queued event removal, active request cancellation, and observer shutdown.
  • Ran a focused TypeScript check on the changed consent and monitoring files — passed.
  • Ran ESLint on the changed files — passed with no errors; existing warnings remain.
  • git diff --check — passed.
  • The full repository test run did not complete and reported unrelated failures. Full type-check, lint, format, and build checks also have repository-level failures, so full CI is not verified as passing.

Merge requirements

A PR is merged only when every box below is true. See
Merge requirements for the full policy.

  • All required CI checks pass on the latest commit (not just an earlier push).
  • No required checks are failing, pending, or skipped — re-run or fix them; do not ask for a merge while any are outstanding.
  • The branch has no merge conflicts with the target branch (rebase or merge master if GitHub shows "This branch has conflicts").
  • Tests were added or updated for the change (primary flow, a boundary case, and a failure case).
  • Docs were updated where behaviour, configuration, or security posture changed.

Closes #834

Prompts users to review analytics consent when the policy changes, and stops telemetry promptly when consent is withdrawn. Adds storage failure handling, tests, and consent documentation.

Closes Nanle-code#834
@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@deslawson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@deslawson is attempting to deploy a commit to the nanle-code's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Manuelshub
Manuelshub merged commit b18bd30 into Nanle-code:master Sep 28, 2026
6 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2026 Security] Add privacy-preserving telemetry consent renewal prompts

2 participants