Versioned Analytics Consent and Immediate Withdrawal - #1106
Merged
Merged
Conversation
Prompts users to review analytics consent when the policy changes, and stops telemetry promptly when consent is withdrawn. Adds storage failure handling, tests, and consent documentation. Closes Nanle-code#834
|
@deslawson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@deslawson is attempting to deploy a commit to the nanle-code's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prompts users to review analytics consent when the policy changes, and stops telemetry promptly when consent is withdrawn. Adds storage failure handling, tests, and consent documentation.
How was this tested?
corepack pnpm exec vitest run --config vitest.config.js src/utils/__tests__/analyticsConsent.test.ts src/utils/__tests__/analytics.circuitBreaker.test.ts src/utils/__tests__/monitoring.consent.test.ts— 15 tests passed. Covers consent grant and withdrawal, stale policy re-prompting, malformed or unavailable storage, failed saves, queued event removal, active request cancellation, and observer shutdown.git diff --check— passed.Merge requirements
A PR is merged only when every box below is true. See
Merge requirements for the full policy.
masterif GitHub shows "This branch has conflicts").Closes #834